Pass slf4j context to spawned thread#3241
Merged
olamy merged 1 commit intoapache:masterfrom Feb 4, 2026
Merged
Conversation
Contributor
Author
|
Anyone able to take a look at this? |
Contributor
Author
|
I cleaned up the imports that caused spotless checks to fail. |
Contributor
Author
|
All the checks have passed, does this look ok to merge? |
|
@olamy Please assign appropriate label to PR according to the type of change. |
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Resolves #2687
Now you have moved to slf4j it would be nice to pass the slf4j mdc context from the parent thread to the threads created by
ThreadedStreamConsumer. The context is really useful for custom logging implementations in maven as when running in parallel mode it lets you do things like prefix the log line with the module name that generated it or grouping all logs by the module and printing them sequentially at the end of the build.The best example of this is in mvnd where they prefix each log line with the module, but it doesn't work for surefire as the logging context is logged in the new thread. If multiple modules are running test at once its not clear which one generated the log line.
Checklist
Following this checklist to help us incorporate your
contribution quickly and easily:
mvn clean installto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean install).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.