Reduce log level for skipped tests result to info#3232
Conversation
@strangelookingnerd Sorry, I don't have any plans for 3.5.5 as I'm working on some refactoring for 3.6.0 (I hope to have some M1 for mid-to-late January), and I don't see anything really urgent for 3.5.5. |
|
@strangelookingnerd Developers don't like the situations if skipped tests are highlighted and too visible. I remember that the Apache wanted my to do exactly opposite and make the skipped tests very visible. Skipped tests are a technical debt and therefore they are not normal tests. Therefore they have to be visible because you should see them properly and work on them. They should not be skipped only because failures are hard to fix and some pressure is made on the developers to move on to the production. We know the reality. |
|
That rather depends on why a test is skipped. If a tests is skipped because it's broken, that's pretty serious. On then other hand, tests because they aren't relevant or useful in a particular environment. E.g. a test that specifically checks the handling of Windows file paths should be skipped on mac OS with no consequences. Somewhere in the middle might be a test that is skipped because a network server isn't available. |
|
@elharo |
This PR proposes to reduce the log level for skipped tests result to
info.In my opinion skipping tests during execution should not raise any concerns as it is usually an active choice by developers.
Utilizing
@Disabledor@Ignoredand the likes is very common in order to (temporarily) skip tests or even prevent execution on different environments and so on.Issuing a warning in the log gives a false sense of something being wrong were in fact everything is just working as intended.
Following this checklist to help us incorporate your
contribution quickly and easily:
mvn clean installto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean install).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.