Skip to content

Replace deprecated methods#198

Merged
elharo merged 7 commits intomasterfrom
null
Jul 27, 2024
Merged

Replace deprecated methods#198
elharo merged 7 commits intomasterfrom
null

Conversation

@elharo
Copy link
Copy Markdown
Contributor

@elharo elharo commented Jul 21, 2024

@elharo elharo requested a review from michael-o July 21, 2024 12:49
@elharo elharo marked this pull request as ready for review July 21, 2024 12:51
michael-o
michael-o requested changes Jul 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@michael-o michael-o left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parts of the Doxia stuff needs to be reverted. I have retained them for a purpose. Will review later.

michael-o
michael-o requested changes Jul 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of backwards compatibility I'd like to keep the marked spots as is.

Comment thread src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java Outdated
Comment thread src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java Outdated
Comment thread src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java Outdated
Comment thread src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java Outdated
Comment thread src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java Outdated
Comment thread src/main/java/org/apache/maven/plugins/site/render/CategorySummaryDocumentRenderer.java Outdated
Comment thread src/main/java/org/apache/maven/plugins/site/render/CategorySummaryDocumentRenderer.java Outdated
Comment thread src/main/java/org/apache/maven/plugins/site/render/ReportDocumentRenderer.java Outdated
Comment thread src/main/java/org/apache/maven/plugins/site/render/SitemapDocumentRenderer.java Outdated
Comment thread src/main/java/org/apache/maven/plugins/site/run/DoxiaFilter.java Outdated
michael-o
michael-o approved these changes Jul 24, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, please squash and merge.

@elharo elharo merged commit bed828c into master Jul 27, 2024
@elharo elharo deleted the null branch July 27, 2024 17:24
michael-o pushed a commit that referenced this pull request Jul 28, 2024
@elharo @michael-o
Replace deprecated methods (#198)
73b57d3 
* Replace deprecated methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-o michael-o michael-o approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elharo @michael-o