[1.9.x] Name mappers cleanup and new GAECV mapper#1674
Merged
cstamas merged 6 commits intoapache:maven-resolver-1.9.xfrom Nov 18, 2025
Merged
Conversation
Cleanup name mappers usage and introduce new, more selective mapper GAECV.
gnodet
reviewed
Nov 18, 2025
| return gavNameMapper(false); | ||
| } | ||
|
|
||
| public static NameMapper gavNameMapper(boolean fileSystemFriendly) { |
Contributor
So we're diminishing lock contentions at the cost of acquiring more locks, right ? |
Member
Author
Yes, client code of SyncContext still asks for same number of artifacts/metadata, but existing GAV name mapper coalesced them into GAV-only. But IMO it is worth it (unless we see something down the road; but then we just need to swap back the default one in adapter), as so far we locked "whole GAV" even if some classifier was needed only, hurting badly concurrency. |
gnodet
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup name mappers usage and introduce new, more selective mapper GAECV.
Changes: