Conversation
kwin
commented
Sep 17, 2024
89e26e2 to
cf6fbd9
Compare
cf6fbd9 to
8a70469
Compare
IndexingSink was always expecting a sectionTitle below each section which doesn't hold. Also close bufferingSink when the section is ended or a new one started (without a preceding sectionTitle) Skip irrelevant index entries (non section type or invalid id) in TOC
8a70469 to
a940182
Compare
michael-o
requested changes
Sep 23, 2024
michael-o
approved these changes
Sep 23, 2024
|
Resolve #866 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
output