Conversation
Contributor
Author
|
what I don't understand is why mdep-839-list isn't picking up this issue |
There was a problem hiding this comment.
Pull request overview
This PR addresses issues #1475 and #1344 by implementing ANSI code stripping when writing dependency output to files, replacing the previous commented-out approach of globally disabling color output.
Key Changes
- Strips ANSI escape codes from output when writing to a file instead of disabling colors at the source
- Adds conditional ANSI stripping logic in the artifact list building process
- Changes module output format from " -- module" to " - module"
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/main/java/org/apache/maven/plugins/dependency/resolvers/ResolveDependenciesMojo.java | Removes commented color control code, adds ANSI stripping logic when outputFile is set, and changes module separator format |
| src/it/projects/mdep-839-list/verify.groovy | Adds assertion to verify ANSI codes are removed and module format is present in output file |
| src/it/projects/mdep-839-list/pom.xml | Updates test description from "list-repositories" to "list" |
| pom.xml | Adds jansi 2.4.2 dependency with test scope and configures it as ignored in dependency analyzer |
Comments suppressed due to low confidence (1)
src/main/java/org/apache/maven/plugins/dependency/resolvers/ResolveDependenciesMojo.java:238
- Changing from " -- module " to " - module " will break multiple existing integration tests that expect the double-dash format. Tests in mdep-571-resolve-java9, mdep-580_display-manifest-automodules, and mdep-839-list all check for " -- module" in their output. If this format change is intentional, all affected tests must be updated; otherwise, revert this change to maintain backward compatibility.
messageBuilder.project(" -- module " + moduleDescriptor.name);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ports modules or not
slachiewicz
approved these changes
Dec 19, 2025
|
@elharo Please assign appropriate label to PR according to the type of change. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1475
fixes #1344
@tiffmaelite