Remove spotbugs-annotations dependencies (#3984)#3985
Merged
vy merged 4 commits intoapache:2.xfrom Nov 25, 2025
Merged
Conversation
dcd1188 to
368e987
Compare
Generated by gradle/develocity-actions |
Contributor
Author
|
I see there are lots of build failures which I can't easily address. However, I would like to hear from the maintainers regarding the idea of dropping the dependency. ChatGPT suggests commit signing from external contributors provides friction yet it adds no value: https://chatgpt.com/share/691b516b-0ff4-800f-9ea4-b53358ed3ae9
|
Member
@vlsi, thanks for raising this issue. I will discuss this further in the mailing list. |
vy
approved these changes
Nov 23, 2025
ppkarwasz
reviewed
Nov 25, 2025
log4j-api/src/main/java/org/apache/logging/log4j/internal/annotation/package-info.java
Outdated
Show resolved
Hide resolved
b9cdb46 to
e329030
Compare
vy
added a commit
to apache/logging-log4j-samples
that referenced
this pull request
Nov 26, 2025
vy
added a commit
that referenced
this pull request
Dec 15, 2025
…, #3985) Co-authored-by: Volkan Yazıcı <volkan@yazi.ci>
vy
added a commit
that referenced
this pull request
Dec 15, 2025
…, #3985) Co-authored-by: Volkan Yazıcı <volkan@yazi.ci>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3984
Checklist
Before we can review and merge your changes, please go through the checklist below. If you're still working on some items, feel free to submit your pull request as a draft—our CI will help guide you through the remaining steps.
✅ Required checks
License: I confirm that my changes are submitted under the Apache License, Version 2.0.
Commit signatures: All commits are signed and verifiable. (See GitHub Docs on Commit Signature Verification).
Code formatting: The code is formatted according to the project’s style guide.
How to check and fix formatting
./mvnw spotless:check./mvnw spotless:applySee the build instructions for details.
Build & Test: I verified that the project builds and all unit tests pass.
How to build the project
Run:
./mvnw verifySee the build instructions for details.
🧪 Tests (select one)
📝 Changelog (select one)
src/changelog/.2.x.x. (See Changelog Entry File Guide).