HTTPCLIENT-2415: Normalize CookieOrigin path for cookie matching#803
Merged
Conversation
ok2c
requested changes
Feb 10, 2026
| this.secure = secure; | ||
| } | ||
|
|
||
| private static String normalizePath(final String path) { |
Member
There was a problem hiding this comment.
@arturobernalg I do not think this is the right place to do path parsing. This logic should belong to the protocol interceptor that instantiates CookieOrigin. The CookieOrigin class itself should be just a bean with no / little protocol logic.
Strip query / fragment from CookieOrigin path per RFC 6265. Add regression tests for request-targets containing '?', '#'.
710f173 to
1a7ae55
Compare
ok2c
approved these changes
Feb 10, 2026
Member
|
@arturobernalg Please cherry-pick to 5.6.x |
arturobernalg
added a commit
that referenced
this pull request
Feb 11, 2026
Strip query / fragment from CookieOrigin path per RFC 6265. Add regression tests for request-targets containing '?', '#'. (cherry picked from commit 9189d11)
Member
Author
done |
Member
Author
|
@ok2c I'll cherry-pick to 5.6.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strip query / fragment from CookieOrigin path per RFC 6265. Add regression tests for request-targets containing '?', '#'.