HTTPCLIENT-2314: Handle gracefully a failure of DnsResolver to return a list of resolved addresses #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ok2c
requested changes
Jan 7, 2024
Member
ok2c
left a comment
There was a problem hiding this comment.
- Please remove my changes from your change-set. If the check is moved to the connection operator it not necessary or even useless in the
SystemDefaultDnsResolver. - Please make symmetric changes to the
MultihomeIOSessionRequester
Contributor
Author
|
@ok2c Thanks for the review. Done |
ok2c
pushed a commit
that referenced
this pull request
Jan 7, 2024
… a list of resolved addresses (#533)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure an
UnknownHostExceptionis thrown, even if a customDnsResolverimplementation is used.Fixes the issue of HTTPCLIENT-2314