fix(dataZoom): restrict range on brushEnd#20814
Merged
100pah merged 2 commits intoapache:masterfrom Mar 18, 2025
Merged
Conversation
|
Thanks for your contribution! |
Contributor
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20814@3e741b1 |
100pah
requested changes
Mar 18, 2025
| linearMap(this._range[0], [0, 100], viewExtend, true), | ||
| linearMap(this._range[1], [0, 100], viewExtend, true) | ||
| ]; | ||
|
|
Member
There was a problem hiding this comment.
- In this sentence
sliderMove(0, this._range, viewExtend, 0, minMaxSpan.minSpan, minMaxSpan.maxSpan);
theviewExtentis pixel value whilethis._rangeis percent value. They do not match. [0, 100]has been defined as a variable aboveconst percentExtent = [0, 100];, thus should use it directly.
Follow what data zoom drag did, the complete code can be:
const viewExtend = this._getViewExtent();
const percentExtent = [0, 100];
const handleEnds = this._handleEnds = [brushShape.x, brushShape.x + brushShape.width];
const minMaxSpan = this.dataZoomModel.findRepresentativeAxisProxy().getMinMaxSpan();
// Restrict range.
sliderMove(
0,
handleEnds,
viewExtend,
0,
minMaxSpan.minSpan != null
? linearMap(minMaxSpan.minSpan, percentExtent, viewExtend, true) : null,
minMaxSpan.maxSpan != null
? linearMap(minMaxSpan.maxSpan, percentExtent, viewExtend, true) : null
);
this._range = asc([
linearMap(handleEnds[0], viewExtend, percentExtent, true),
linearMap(handleEnds[1], viewExtend, percentExtent, true)
]);
this._updateView();
this._dispatchZoomAction(false);
100pah
approved these changes
Mar 18, 2025
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fixed issues
fixed #20807
Details
Before: What was the problem?
After: How does it behave after the fixing?
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information