Conversation
|
Thanks for your contribution! The pull request is marked to be Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the |
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20226@78c072c |
There was a problem hiding this comment.
Do we need to enable it to pass the additional user params to renderItem, as discussed earlier?
Custom rendering logic provider:
function myRenderItem(params) {
console.log( params.renderItemArgs );
// params.renderItemArgs is required in the following rendering logic.
}
echarts.registerCustomSeries('perfectRenderItem', myRenderItem);Custom rendering logic user:
option = {
series: {
type: 'custom',
renderItem: 'perfectRenderItem',
renderItemArgs: {abc: 123, def: 'haha'}
}
}| @@ -0,0 +1,11 @@ | |||
| import { CustomSeriesRenderItem } from './CustomSeries'; | |||
There was a problem hiding this comment.
Use import type explictly to ensure the CustomSeries is not in the depedencies of core/echarts
import type { CustomSeriesRenderItem } ...|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Brief Information
This pull request is in the type of:
What does this PR do?
Custom series provide a powerful way to let developers define their own charts. But for now, it's hard to reuse the
renderItemfor other projects or other developers. This PR provides a way to register custom series so that developer A can make a custom series and publish it (probably by npm) and developer B can use it by simply settingrenderItemto the related name.Fixed issues
Details
Before: What was the problem?
Custom series is hard to be reused.
After: How does it behave after the fixing?
Making a reusable custom series:
Using the above custom series:
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information