Skip to content

Fix dubbo service name bug #11038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlbumenJ merged 3 commits into from
Nov 28, 2022
Merged

Fix dubbo service name bug #11038

AlbumenJ merged 3 commits into from
Nov 28, 2022

Conversation

@hujun-w-2
Copy link
Contributor

@hujun-w-2 hujun-w-2 commented Nov 28, 2022

What is the purpose of the change

for #10732

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

AlbumenJ
AlbumenJ requested changes Nov 28, 2022
View reviewed changes
...gistry/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/NacosRegistry.java Outdated
private void doSubscribe(final URL url, final NotifyListener listener, final Set<String> serviceNames) {
execute(namingService -> {
if (isServiceNamesWithCompatibleMode(url)) {
List<Instance> allCorrespondingInstanceList = Lists.newArrayList();
Copy link
Member

@AlbumenJ AlbumenJ Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove guava usage

Copy link
Contributor Author

@hujun-w-2 hujun-w-2 Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2022 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 60.87%. Comparing base (b4386f9) to head (b542012).

Files with missing lines Patch % Lines
...org/apache/dubbo/registry/nacos/NacosRegistry.java 75.00% 3 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master   #11038      +/-   ##
============================================
+ Coverage     60.82%   60.87%   +0.05%     
  Complexity      447      447              
============================================
  Files          1101     1100       -1     
  Lines         44542    44520      -22     
  Branches       6492     6488       -4     
============================================
+ Hits          27092    27101       +9     
+ Misses        14471    14449      -22     
+ Partials       2979     2970       -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

AlbumenJ
AlbumenJ approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit 1a9eda5 into apache:master Nov 28, 2022
@AlbumenJ AlbumenJ mentioned this pull request Nov 29, 2022
Closed
HankDevelop pushed a commit to HankDevelop/dubbo that referenced this pull request Jan 1, 2023
@hujun-w-2 @HankDevelop
Fix dubbo service name bug (apache#11038)
ac61812
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlbumenJ AlbumenJ AlbumenJ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hujun-w-2 @codecov-commenter @AlbumenJ