Skip to content

Bigquery fixes#32780

Merged
damccorm merged 2 commits intoapache:masterfrom
claudevdm:bigquery-batch-fix
Oct 16, 2024
Merged

Bigquery fixes#32780
damccorm merged 2 commits intoapache:masterfrom
claudevdm:bigquery-batch-fix

Conversation

@claudevdm
Copy link
Copy Markdown
Collaborator

@claudevdm claudevdm commented Oct 15, 2024 •
edited
Loading

Fix the following BigQuery enrichment transform issues

  1. Conditions on more than one field returns duplicate rows
  2. Batching returns incorrect results (checks equality of restriction field on all columns of the returned data)
  3. Batched_condition_template does not wrap conditions in parenthesis

Issues 1 and 2 are fixed by keying batched requests by a tuple of values.
Issue 3 is fixed by wrapping conditions in parenthesis.

Also modify integration tests to

  1. Set up and tear down a new table on each test
  2. Add test cases for above mentioned issues
  3. Verify actual enriched pcollection output

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@claudevdm claudevdm marked this pull request as ready for review October 15, 2024 18:15
@claudevdm
Copy link
Copy Markdown
Collaborator Author

claudevdm commented Oct 15, 2024

R: @damccorm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 15, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

damccorm
damccorm reviewed Oct 15, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just had one comment, otherwise this LGTM

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 58.90%. Comparing base (301286f) to head (b17abe9).
Report is 130 commits behind head on master.

Files with missing lines Patch % Lines
...he_beam/transforms/enrichment_handlers/bigquery.py 33.33% 8 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master   #32780      +/-   ##
============================================
+ Coverage     58.84%   58.90%   +0.05%     
  Complexity     3091     3091              
============================================
  Files          1130     1131       +1     
  Lines        174044   174444     +400     
  Branches       3320     3312       -8     
============================================
+ Hits         102414   102753     +339     
- Misses        68293    68360      +67     
+ Partials       3337     3331       -6
Flag Coverage Δ
python 81.42% <33.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

damccorm
damccorm approved these changes Oct 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Yaml test failures are unrelated and failing at head, so merging

@damccorm damccorm merged commit 6b3a1b2 into apache:master Oct 16, 2024
reeba212 pushed a commit to reeba212/beam that referenced this pull request Dec 4, 2024
@claudevdm @reeba212
Bigquery fixes (apache#32780)
74dd101 
* Bigquery fixes

* Remove unnecessary comprehension loop

---------

Co-authored-by: Claude <cvandermerwe@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damccorm damccorm damccorm approved these changes

Assignees

No one assigned

Labels

build python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@claudevdm @damccorm