[Managed Iceberg] Add support for TIMESTAMP, TIME, and DATE types#32688
[Managed Iceberg] Add support for TIMESTAMP, TIME, and DATE types#32688ahmedabu98 merged 15 commits intoapache:masterfrom
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
assign set of reviewers |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergUtils.java
Outdated
Show resolved
Hide resolved
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergUtils.java
Show resolved
Hide resolved
|
Thanks for taking an initial look @DanielMorales9. This PR is ready for another review |
|
Beam ( I added support for String timestamps to be parsed to OffsetDateTime. But I wonder if it makes sense to allow other types as well (LocalDateTime, joda DateTime, long) and resolve all these types to OffsetDateTime at UTC. This will allow us to have a more unified approach to timestamps - and Iceberg always resolves to UTC anyways so there's no harm in doing it from our side |
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergUtils.java
Outdated
Show resolved
Hide resolved
…ql.datetime and timestamptTZ returns datetime
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergUtils.java
Outdated
Show resolved
Hide resolved
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergUtils.java
Show resolved
Hide resolved
|
Thanks for the LGTM -- will merge when tests pass |
…ache#32688) * support timestamp, time, date types * add to changes md * always write java time LocalDateTime for iceberg TIMESTAMP * update java doc * add timezone support with Strings * clean up; reading iceberg timestamptz will return sqltype.datetime * support string, long, sql.datetime, and datetime; timestamp returns sql.datetime and timestamptTZ returns datetime
Fixes #32680