Enrichment Transform with BigTable handler#30001
Merged
riteshghorse merged 45 commits intoapache:masterfrom Jan 19, 2024
Merged
Enrichment Transform with BigTable handler#30001riteshghorse merged 45 commits intoapache:masterfrom
riteshghorse merged 45 commits intoapache:masterfrom
Conversation
damccorm
reviewed
Jan 16, 2024
Contributor
damccorm
left a comment
There was a problem hiding this comment.
Mostly looks good, though I didn't get a chance to look at the enrichment_handlers folder yet. Leaving comments for the pieces I've reviewed so far
Contributor
Author
|
Thanks for the review! Made the suggested changes. |
damccorm
reviewed
Jan 16, 2024
Contributor
damccorm
left a comment
There was a problem hiding this comment.
BigTable piece mostly LGTM as well, just have some lingering comments
sdks/python/apache_beam/transforms/enrichment_handlers/bigtable.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks! Made the changes from last review. Throttle test cases are left. Feel free to defer the review until that or up to you! |
damccorm
reviewed
Jan 17, 2024
sdks/python/apache_beam/transforms/enrichment_handlers/bigtable.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/transforms/enrichment_handlers/bigtable.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Added the throttle unit test. Bigtable improvements are remaining now. |
damccorm
reviewed
Jan 18, 2024
sdks/python/apache_beam/transforms/enrichment_handlers/bigtable.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thank you for your reviews! I'll merge once the tests pass |
damccorm
reviewed
Jan 18, 2024
Contributor
Author
|
Tests passed. Removing the trigger file |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the implementation of:
Cross-lang enablement and caching will be added in subsequent PRs.
Part of #29787
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.