Clickhouse support low cardinality#29533
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
I do not think this failure is related to my implementation |
|
assign set of reviewers |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Abacn
left a comment
There was a problem hiding this comment.
Thanks, this looks good to me. Had a comment about documentaion
| * </table> | ||
| * | ||
| * Nullable row columns are supported through Nullable type in ClickHouse. | ||
| * Nullable row columns are supported through Nullable type in ClickHouse. Adding support for <a |
There was a problem hiding this comment.
This is javadoc. The statement "Adding support ..." sounds like an announcement and consider moving it to CHANGES.md
For here, consider phrasing like "Low cardinality hint is supported through LowCardinality DataType in ClickHouse."
Abacn
left a comment
There was a problem hiding this comment.
Thanks, LGTM, will merge once tests passed
Co-authored-by: Yi Hu <huuyyi@gmail.com>
Support for LowCardinality for ClickHouse.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.