Remove Tensorflow from default Beam images.#28424
Conversation
|
The 2.50 images were around 4.13GB (according to my local docker). What's the new total without tensor flow? (It would be good to have in the PR description anyway). |
Codecov Report
@@ Coverage Diff @@
## master #28424 +/- ##
==========================================
+ Coverage 72.33% 72.35% +0.01%
==========================================
Files 682 682
Lines 100541 100541
==========================================
+ Hits 72730 72748 +18
+ Misses 26238 26216 -22
- Partials 1573 1577 +4
Flags with carried forward coverage won't be shown. Click here to find out more. see 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This number (unpacked image) reduces to 2.67 GB |
bvolpato
left a comment
There was a problem hiding this comment.
It makes sense to me. LGTM.
Might be good to send a note to users@ and/or highlight this when the release is coming out
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Including TF significantly increases the size of default Beam container images. Given that some Beam users use other ML framework, including TF but not other, equally large dependencies, seems less obvious.
I suggest we remove TF for now, which shaves almost 1.5 GB from unpacked image.
If you have been negatively affected by this change, please comment on #20605 - we would like to collect user input to prioritize this effort accordingly.
For tips on Python runtime dependency management, see : https://beam.apache.org/documentation/sdks/python-pipeline-dependencies.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.