Skip to content

[release-2.69] Cherrypick #36572 - Revert "Add GRPC experiments to Python dockerfile #36573

Merged
tvalentyn merged 1 commit intoapache:release-2.69from
tvalentyn:cp-pr-36572
Oct 20, 2025
Merged

[release-2.69] Cherrypick #36572 - Revert "Add GRPC experiments to Python dockerfile #36573
tvalentyn merged 1 commit intoapache:release-2.69from
tvalentyn:cp-pr-36572

Conversation

@tvalentyn
Copy link
Copy Markdown
Contributor

@tvalentyn tvalentyn commented Oct 20, 2025

This reverts commit d687f4f.

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Oct 20, 2025

Summary of Changes

Hello @tvalentyn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is a cherry-pick to the release-2.69 branch, specifically reverting a commit that introduced GRPC experiment environment variables into the Python Dockerfile. The purpose of this revert is to remove the experimental GRPC settings from the Python container build process, likely addressing an issue or a decision to not proceed with these specific configurations in this release branch.

Highlights

  • Revert GRPC Experiment Variables: This pull request reverts a previous change that added GRPC_EXPERIMENTS and GRPC_ENABLE_FORK_SUPPORT environment variables to the Python Dockerfile.
  • Python Dockerfile Modification: The change specifically targets the sdks/python/container/Dockerfile, removing the lines that enabled these experimental GRPC settings.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@tvalentyn tvalentyn mentioned this pull request Oct 20, 2025
Merged
@tvalentyn
Copy link
Copy Markdown
Contributor Author

tvalentyn commented Oct 20, 2025

R: @Abacn @Amar3tto

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 20, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 20, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-2.69@ecdc49b). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff               @@
##             release-2.69   #36573   +/-   ##
===============================================
  Coverage                ?   36.24%           
  Complexity              ?     1667           
===============================================
  Files                   ?     1060           
  Lines                   ?   165581           
  Branches                ?     1195           
===============================================
  Hits                    ?    60013           
  Misses                  ?   103395           
  Partials                ?     2173
Flag Coverage Δ
python 40.51% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvalentyn tvalentyn merged commit 976cbc3 into apache:release-2.69 Oct 20, 2025
107 of 112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Abacn Abacn Abacn approved these changes

Assignees

No one assigned

Labels

docker python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tvalentyn @Abacn