Skip to content

CP: Fix publishing of ml/distroless images (#36548)#36565

Merged
damccorm merged 1 commit intorelease-2.69from
users/damccorm/ml-cp
Oct 20, 2025
Merged

CP: Fix publishing of ml/distroless images (#36548)#36565
damccorm merged 1 commit intorelease-2.69from
users/damccorm/ml-cp

Conversation

@damccorm
Copy link
Copy Markdown
Contributor

@damccorm damccorm commented Oct 20, 2025

This should allow us to publish ML/distroless containers as part of the normal flow.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Oct 20, 2025

Summary of Changes

Hello @damccorm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue preventing the seamless publishing of ML and distroless container images within the standard build pipeline. It integrates the publishing steps for these specialized images directly into the existing Python container build tasks, making their release a more consistent part of the normal build process. Additionally, it includes a minor correction to ensure license scripts are correctly located and copied for ML containers.

Highlights

  • Integrated ML/Distroless Image Publishing: The build process for standard Python container images now conditionally triggers the publishing of corresponding ML and distroless images, streamlining their release into the normal flow when specific properties are enabled.
  • Refined Gradle Dependencies: The pushAll task has been updated to remove explicit dependencies on aggregate ML and distroless pushAll tasks, as their publishing is now handled by the individual Python version docker tasks.
  • Corrected License Script Path: An incorrect relative path for copying license scripts within the ML container build configuration has been fixed, ensuring proper inclusion of license information.
Ignored Files
  • Ignored by pattern: .github/workflows/** (3)
    • .github/workflows/beam_Publish_Beam_SDK_Snapshots.yml
    • .github/workflows/build_release_candidate.yml
    • .github/workflows/republish_released_docker_containers.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@damccorm
Copy link
Copy Markdown
Contributor Author

damccorm commented Oct 20, 2025

R: @Abacn @Amar3tto

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 20, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Amar3tto Amar3tto self-requested a review October 20, 2025 16:22
@damccorm damccorm merged commit c6e2df0 into release-2.69 Oct 20, 2025
114 of 118 checks passed
@damccorm damccorm deleted the users/damccorm/ml-cp branch October 20, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Amar3tto Amar3tto Amar3tto approved these changes

Assignees

No one assigned

Labels

build docker python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@damccorm @Amar3tto