Skip to content

[release-2.69] Cherrypick #36518 to the branch.#36551

Merged
damccorm merged 6 commits intoapache:release-2.69from
tvalentyn:dofn_start
Oct 20, 2025
Merged

[release-2.69] Cherrypick #36518 to the branch.#36551
damccorm merged 6 commits intoapache:release-2.69from
tvalentyn:dofn_start

Conversation

@tvalentyn
Copy link
Copy Markdown
Contributor

@tvalentyn tvalentyn commented Oct 16, 2025 •
edited
Loading

#36518 adds an observability improvement to Python SDK that would be nice to include it with 2.69.0 if we have another RC. Otherwise it will go in the next release.

R: @Amar3tto

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Oct 16, 2025

Summary of Changes

Hello @tvalentyn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates a critical observability enhancement into the Apache Beam Python SDK for the release-2.69 branch. The primary goal is to provide better visibility into the lifecycle of bundle processors, particularly when they are being created or are processing elements. By tracking creation times and implementing timeout-based logging and termination, the changes aim to help identify and resolve issues related to stuck or slow bundle processor initialization and execution, ultimately improving the stability and debuggability of Beam pipelines.

Highlights

  • Enhanced Observability for Python SDK: This pull request cherry-picks an improvement to the Python SDK, specifically enhancing observability around the creation and processing of bundle processors within the worker. It introduces mechanisms to track and report on bundle processors that are taking an unusually long time to initialize or process.
  • Tracking Bundle Processor Creation: A new internal dictionary, processors_being_created, has been added to the SdkWorker to keep track of bundle processors that are currently in the process of being instantiated. This allows for monitoring their creation duration.
  • Improved Worker Status Reporting: The worker status reporting (worker_status.py) now includes a dedicated section for 'Processors being created', displaying details such as the instruction ID, bundle ID, the thread involved, and the time elapsed since creation began. This provides clearer insight into potential bottlenecks during processor setup.
  • Timeout-Based Lull Logging and Termination: New logic has been implemented to detect and log warnings or errors if bundle processor creation or processing exceeds predefined timeout thresholds. In severe cases, if an element processing timeout is exceeded during creation, the SDK harness will be terminated, providing a stack trace for debugging.
  • Refactoring and Test Coverage: Variable names related to bundle processor caches have been refactored for consistency, and comprehensive unit tests have been added to validate the new lull logging and timeout-based termination functionalities, ensuring the robustness of these observability improvements.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 16, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 56.09756% with 18 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-2.69@8739e50). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...python/apache_beam/runners/worker/worker_status.py 52.63% 18 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##             release-2.69   #36551   +/-   ##
===============================================
  Coverage                ?   55.09%           
  Complexity              ?     1667           
===============================================
  Files                   ?     1060           
  Lines                   ?   165581           
  Branches                ?     1195           
===============================================
  Hits                    ?    91222           
  Misses                  ?    72186           
  Partials                ?     2173
Flag Coverage Δ
python 80.99% <56.09%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 16, 2025

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

damccorm
damccorm approved these changes Oct 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm damccorm merged commit b48d832 into apache:release-2.69 Oct 20, 2025
116 of 121 checks passed
@tvalentyn tvalentyn mentioned this pull request Oct 20, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damccorm damccorm damccorm approved these changes

Assignees

No one assigned

Labels

python runners

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tvalentyn @damccorm