Skip to content

Skip TestTimers_ProcessingTime_Unbounded for spark.#36527

Merged
damccorm merged 2 commits intoapache:masterfrom
shunping:issue-31475
Oct 15, 2025
Merged

Skip TestTimers_ProcessingTime_Unbounded for spark.#36527
damccorm merged 2 commits intoapache:masterfrom
shunping:issue-31475

Conversation

@shunping
Copy link
Copy Markdown
Collaborator

fixes #31475

@github-actions github-actions bot added the go label Oct 15, 2025
@shunping shunping requested a review from Amar3tto October 15, 2025 15:40
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @shunping, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where a specific timer-related integration test was incompatible with the Apache Spark runner. By adding this test to the list of filtered tests for Spark, the PR ensures that the test suite remains stable and passes without encountering failures related to Spark's current limitations regarding side inputs in executable stages. This change improves the overall reliability of the Go SDK's integration tests when executed with Spark.

Highlights

  • Test Skipping for Spark Runner: The TestTimers_ProcessingTime_Unbounded integration test is now explicitly skipped when running against the Apache Spark runner.
  • Reason for Skipping: This test is skipped due to the Spark runner's current lack of support for side inputs within the executable stage.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@shunping shunping self-assigned this Oct 15, 2025
@Abacn
Copy link
Copy Markdown
Contributor

Abacn commented Oct 15, 2025

would you mind adding a trigger file to make postcommit exercised in this PR?

Copy link
Copy Markdown
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm damccorm merged commit ed39503 into apache:master Oct 15, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PostCommit Go VR Spark job is flaky

4 participants