[Java] Fix expensive OneOfType precondition messages by making them lazy#36063
[Java] Fix expensive OneOfType precondition messages by making them lazy#36063scwhittle merged 1 commit intoapache:masterfrom
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @scwhittle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request optimizes the generation of error messages within the OneOfType class by implementing lazy evaluation for precondition checks. This change prevents potentially expensive toString() calls on complex schema types from executing unnecessarily when no error occurs, thereby improving overall performance.
Highlights
- Performance Improvement: Precondition error messages in OneOfType are now constructed lazily to avoid expensive toString() calls on schema types when the precondition passes.
- Code Refinement: Updated checkArgument and checkNotNull calls to use formatted strings, deferring the evaluation of the error message until it's needed.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
failures look unrelated |
|
cc @Amar3tto |
Abacn
left a comment
There was a problem hiding this comment.
this sounds a format fix / optimization should not be a release blocker I understand
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
It is a pretty bad cpu issue when encountered, 60% of one pipelines. So if it is easy to cherrypick before building release artifacts it would be appreciated. |
|
Thanks for the context, opened #36070 |
Previously the error string was constructed eagerly and OneOfType.toString calls toString on all the types. Those can be expensive, for example schemas.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.