Merged
Conversation
2990de5 to
a6311f5
Compare
a6311f5 to
aa53511
Compare
Collaborator
Author
|
R: @damccorm |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
damccorm
reviewed
Feb 3, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #33841 +/- ##
============================================
- Coverage 59.48% 59.48% -0.01%
Complexity 4683 4683
============================================
Files 1348 1349 +1
Lines 184681 184902 +221
Branches 4455 4455
============================================
+ Hits 109852 109981 +129
- Misses 71088 71180 +92
Partials 3741 3741
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…t is default and how to override defaults or go full custom.
damccorm
pushed a commit
that referenced
this pull request
Feb 5, 2025
* Add AlloyDB vector writer. * Resolve comments. * Add default ConflictResolution as ON CONFLICT DO NOTHING. * Disable tests. * Fix docstring errors. * Simplify ColumnSpec's usage, add builder class to make it obvious what is default and how to override defaults or go full custom. * Fix linter error.
3 tasks
damccorm
added a commit
that referenced
this pull request
Feb 5, 2025
* Add AlloyDB vector writer. * Resolve comments. * Add default ConflictResolution as ON CONFLICT DO NOTHING. * Disable tests. * Fix docstring errors. * Simplify ColumnSpec's usage, add builder class to make it obvious what is default and how to override defaults or go full custom. * Fix linter error. Co-authored-by: claudevdm <33973061+claudevdm@users.noreply.github.com>
VardhanThigle
pushed a commit
to VardhanThigle/beam
that referenced
this pull request
Mar 21, 2025
* Add AlloyDB vector writer. * Resolve comments. * Add default ConflictResolution as ON CONFLICT DO NOTHING. * Disable tests. * Fix docstring errors. * Simplify ColumnSpec's usage, add builder class to make it obvious what is default and how to override defaults or go full custom. * Fix linter error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabled test while I figure out how to configure the database arguments to run in dataflow and github action runners.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.