Cherry-pick #33505 to 2.62.0 release branch (Build wheels on gha runners instead of local runners)#33546
Conversation
* Debug wheels * Try gha runners * Add back other workflows * Update build_wheels.yml
|
R: @kennknowles |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
kennknowles
left a comment
There was a problem hiding this comment.
I don't think I really understand the full implications of this. It is a pull_request trigger so it does not have security risks, yes? (whereas pull_request_target would?)
And is there a performance / reliability / runner backlog issue possible here?
|
I expect that only the change already on |
This is true, though we're actually lowering the permission set here (it doesn't have access to our self-hosted service account)
There is a problem with self-hosted runners, tracked here - #33506 |
This is needed to avoid failures like https://github.com/apache/beam/actions/runs/12692477655
References:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.