Skip to content

Revert "Portable runner fixes"#32271

Merged
lostluck merged 1 commit intomasterfrom
revert-32247-portable-runner-fixes
Aug 21, 2024
Merged

Revert "Portable runner fixes"#32271
lostluck merged 1 commit intomasterfrom
revert-32247-portable-runner-fixes

Conversation

@lostluck
Copy link
Copy Markdown
Contributor

Reverts #32247

It causes pipelines to pass that should fail, so reverting.

@lostluck
Copy link
Copy Markdown
Contributor Author

R: @Abacn @damondouglas

@lostluck lostluck requested review from Abacn and damondouglas August 21, 2024 17:21
@github-actions
Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Abacn
Copy link
Copy Markdown
Contributor

Abacn commented Aug 21, 2024

Copy link
Copy Markdown
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PostCommit Java ValidatesRunner ULR passed

@lostluck lostluck merged commit c5bf5fc into master Aug 21, 2024
@lostluck lostluck deleted the revert-32247-portable-runner-fixes branch August 21, 2024 18:47
reeba212 pushed a commit to reeba212/beam that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants