Make ReadFromBigQueryRequest id more randomized#30156
Make ReadFromBigQueryRequest id more randomized#30156ahmedabu98 merged 3 commits intoapache:masterfrom
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| @@ -2926,7 +2928,7 @@ def __init__( | |||
| self.validate() | |||
|
|
|||
| # We use this internal object ID to generate BigQuery export directories. | |||
There was a problem hiding this comment.
Shall we update this code comment?
There was a problem hiding this comment.
Nothing changed really, the comment is still valid. I guess we can also include that this is used to create job names
|
Since the fix is simple, if we do RC2, shall we cherry-pick this one? cc @lostluck |
If it's a regression, it's a case for an RC2. Otherwise, I'm happy to fast track a simple fix in case we do need an RC2. |
Sounds good! Will create a CP if that happens |
… randomized (#30217) * make ReadFromBigQueryRequest id more randomized * lint * update comment --------- Co-authored-by: Ahmed Abualsaud <ahmedabualsaud@google.com>
Request ID is just a random number between (0, 100,000). For long streaming jobs, this will inevitably create requests with identical ID's. This becomes a problem because query jobs are created from these IDs and BQ ignores identical job names.