Skip to content

[cherry-pick] Remove setting _beam_schema_proto (#29754)#29759

Merged
jrmccluskey merged 1 commit intoapache:release-2.53.0from
riteshghorse:cp-commit
Dec 14, 2023
Merged

[cherry-pick] Remove setting _beam_schema_proto (#29754)#29759
jrmccluskey merged 1 commit intoapache:release-2.53.0from
riteshghorse:cp-commit

Conversation

@riteshghorse
Copy link
Copy Markdown
Contributor

@riteshghorse riteshghorse commented Dec 13, 2023

CP of #29754

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@riteshghorse
Copy link
Copy Markdown
Contributor Author

riteshghorse commented Dec 13, 2023

Run Python 3.11 PostCommit

@riteshghorse
Copy link
Copy Markdown
Contributor Author

riteshghorse commented Dec 13, 2023

R: @Abacn @jrmccluskey

jrmccluskey
jrmccluskey approved these changes Dec 13, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 13, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@jrmccluskey
Copy link
Copy Markdown
Contributor

jrmccluskey commented Dec 13, 2023

Will merge once checks pass just for safety

@riteshghorse
Copy link
Copy Markdown
Contributor Author

riteshghorse commented Dec 14, 2023

The failing PC test passed
image

@riteshghorse
Copy link
Copy Markdown
Contributor Author

riteshghorse commented Dec 14, 2023

The failure is because of a bigquery test timeout

�[1m�[31mE     RuntimeError: Timeout after 600 seconds while waiting for job 2023-12-13_13_37_27-7365213249556534026 enters expected state RUNNING. Current state is PENDING.�[0m

�[1m�[31mapache_beam/runners/dataflow/test_dataflow_runner.py�[0m:103: RuntimeError

�[33mDuring handling of the above exception, another exception occurred:�[0m

self = <apache_beam.io.gcp.bigquery_io_read_it_test.BigqueryIOReadIT testMethod=test_bigquery_read_1M_python>

    @pytest.mark.it_postcommit
    def test_bigquery_read_1M_python(self):
>     self.run_bigquery_io_read_pipeline('1M')

�[1m�[31mapache_beam/io/gcp/bigquery_io_read_it_test.py�[0m:68:

@riteshghorse
Copy link
Copy Markdown
Contributor Author

riteshghorse commented Dec 14, 2023

Run Python 3.11 PostCommit

@jrmccluskey jrmccluskey merged commit 03e9036 into apache:release-2.53.0 Dec 14, 2023
@riteshghorse riteshghorse deleted the cp-commit branch December 14, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrmccluskey jrmccluskey jrmccluskey approved these changes

Assignees

No one assigned

Labels

python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@riteshghorse @jrmccluskey