Skip to content

Remove setting _beam_schema_proto #29754

Merged
riteshghorse merged 1 commit intoapache:masterfrom
riteshghorse:test-rm-line
Dec 13, 2023
Merged

Remove setting _beam_schema_proto #29754
riteshghorse merged 1 commit intoapache:masterfrom
riteshghorse:test-rm-line

Conversation

@riteshghorse
Copy link
Copy Markdown
Contributor

@riteshghorse riteshghorse commented Dec 13, 2023

Fixes #29684

Remove this line for now to unblock the release cut. Filed #29756


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@riteshghorse
Copy link
Copy Markdown
Contributor Author

Run Python 3.11 PostCommit

@riteshghorse riteshghorse changed the title [Testing] test revert _beam_schema_proto Remove setting _beam_schema_proto Dec 13, 2023
@riteshghorse riteshghorse marked this pull request as ready for review December 13, 2023 20:04
@riteshghorse riteshghorse added this to the 2.53.0 Release milestone Dec 13, 2023
@github-actions
Copy link
Copy Markdown
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @liferoad for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@riteshghorse
Copy link
Copy Markdown
Contributor Author

riteshghorse commented Dec 13, 2023

R: @Abacn @robertwb

@github-actions
Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Copy Markdown
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Abacn
Copy link
Copy Markdown
Contributor

Abacn commented Dec 13, 2023

Also, this needs a cherry pick into release-2.53.0 after PR gets merged

@riteshghorse riteshghorse merged commit c49e9ec into apache:master Dec 13, 2023
riteshghorse added a commit to riteshghorse/beam that referenced this pull request Dec 13, 2023
riteshghorse added a commit to riteshghorse/beam that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Failing Test]: Python PostCommits are failing due to a possible dependency update

2 participants