Skip to content

[Cherry Pick #28083][prism] support single external env pipelines.#28111

Merged
lostluck merged 2 commits intoapache:release-2.50.0from
lostluck:cp28083
Aug 22, 2023
Merged

[Cherry Pick #28083][prism] support single external env pipelines.#28111
lostluck merged 2 commits intoapache:release-2.50.0from
lostluck:cp28083

Conversation

@lostluck
Copy link
Copy Markdown
Contributor

Unblock users from running non-go pipelines against prism if they are single external/loopback environments.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@lostluck
Copy link
Copy Markdown
Contributor Author

R: @jrmccluskey for the cherry pick.

Copy link
Copy Markdown
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@lostluck lostluck added this to the 2.50.0 Release milestone Aug 22, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 22, 2023

Codecov Report

Merging #28111 (9373317) into release-2.50.0 (c42daee) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@                Coverage Diff                 @@
##           release-2.50.0   #28111      +/-   ##
==================================================
- Coverage           70.84%   70.84%   -0.01%     
==================================================
  Files                 861      861              
  Lines              105046   105054       +8     
==================================================
+ Hits                74422    74427       +5     
- Misses              29062    29064       +2     
- Partials             1562     1563       +1     
Flag Coverage Δ
go 53.66% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
sdks/go/pkg/beam/runners/prism/internal/execute.go 90.75% <66.66%> (-1.42%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lostluck lostluck merged commit 8293bbd into apache:release-2.50.0 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants