Skip to content

[#27842] Cherry pick using a file for PipelineOptions.#28015

Merged
lostluck merged 1 commit intoapache:release-2.50.0from
lostluck:cpFileOpts
Aug 15, 2023
Merged

[#27842] Cherry pick using a file for PipelineOptions.#28015
lostluck merged 1 commit intoapache:release-2.50.0from
lostluck:cpFileOpts

Conversation

@lostluck
Copy link
Copy Markdown
Contributor

Cherry picks fix for #27842 to release branch. Should resolve Arguments Too Long errors for the 2.50 release.

It's SDK side sibling is already in the branch: #27841


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@lostluck lostluck changed the title [#27842] Cp file opts [#27842] Cherry pick using a file for PipelineOptions. Aug 15, 2023
@lostluck lostluck changed the base branch from master to release-2.50.0 August 15, 2023 21:26
@chamikaramj
Copy link
Copy Markdown
Contributor

LGTM.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 15, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-2.50.0@50e2495). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             release-2.50.0   #28015   +/-   ##
=================================================
  Coverage                  ?   72.31%           
=================================================
  Files                     ?      678           
  Lines                     ?    99740           
  Branches                  ?        0           
=================================================
  Hits                      ?    72125           
  Misses                    ?    26054           
  Partials                  ?     1561           
Flag Coverage Δ
go 53.67% <0.00%> (?)
python 82.87% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Copy Markdown
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @liferoad for label python.
R: @Abacn for label java.
R: @chamikaramj for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@lostluck lostluck merged commit c42daee into apache:release-2.50.0 Aug 15, 2023
@lostluck lostluck deleted the cpFileOpts branch August 15, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants