refactor!: move head to ObjectStoreExt#543
Merged
Merged
Conversation
alamb
approved these changes
Nov 18, 2025
| } | ||
|
|
||
| async fn head(&self, location: &Path) -> Result<ObjectMeta> { | ||
| let options = GetOptions::new().with_head(true); |
Contributor
There was a problem hiding this comment.
TIL that GetOpts already has with_head 🤯
The more I see of these PRs to extract code into ObjectStoreExt the better I like it
kylebarron
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ObjectStoretrait: Split out convenience methods #385ObjectStoreExttrait #405.Rationale for this change
headis justget_opts+with_head(true).What changes are included in this PR?
Are there any user-facing changes?
Breaking:
headmoved fromObjectStoretoObjectStoreExt.