Replace Path::child with Path::join#666
Merged
Merged
Conversation
Kinrany
commented
Mar 18, 2026
|
|
||
| // two dir prefix matches | ||
| let needle = needle.child("baz%2Ftest"); | ||
| let needle = needle.join("baz%2Ftest"); |
Contributor
Author
There was a problem hiding this comment.
A test with an example of an unnecessary clone being removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #665.
What changes are included in this PR?
This is the version where we add a new method and immediately deprecate
Path::child, making it easy for the users to migrate by inlining.Proof of concept: shows one possible implementation, but likely needs minor changes at the very least.
Are there any user-facing changes?
Adds
Path::joinand deprecatesPath::child.No breaking changes yet, but implies that
Path::childwill be removed in the future.