fix: missing 5xx error body when retry exhausted#618
Merged
Conversation
Contributor
|
CI got fixed in the meantime, can you please rebase? |
4 tasks
Contributor
|
Hi @jackye1995 -- we are preparing for another object store release next week and would like to include this PR. I merged up from main to try and get a clean CI run |
crepererum
approved these changes
Mar 19, 2026
crepererum
left a comment
Contributor
There was a problem hiding this comment.
looks good now, thanks @jackye1995 for the implementation and @alamb for the rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #617
Rationale for this change
Currently we only capture the error body after retry exhausted for client 4xx error. This makes it unclear about the exact S3 error message when the error is a server 5xx error.
What changes are included in this PR?
Make sure we always capture the error response body after retry exhausted.
Are there any user-facing changes?
No user facing or breaking changes