Prevent compilation error with all cloud features but fs turned on#412
Merged
Conversation
Contributor
Author
|
@mbrobbel thanks for the review; rebased on the latest main to fix clippy warnings. |
crepererum
pushed a commit
to crepererum/arrow-rs-object-store
that referenced
this pull request
Jul 10, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #411 .
Rationale for this change
Allows the crate to compile with
--no-default-features --features=aws,azure,gcp,httpWhat changes are included in this PR?
Adds a missing feature test for including a fallback case in the relevant match statement. I could also add this set of feature flags to CI if desired but not sure it's worth it?
Are there any user-facing changes?
Just the lack of compilation failure.