Split out arrow-ord (#2594)#3299
Merged
Merged
Conversation
tustvold
commented
Dec 8, 2022
bbb07b7 to
e844da8
Compare
tustvold
commented
Dec 8, 2022
Contributor
Author
There was a problem hiding this comment.
Parquet doesn't actually depend on any of these kernels, and so this can be removed
db961ea to
540af48
Compare
tustvold
commented
Dec 8, 2022
| - arrow-ipc/** | ||
| - arrow-schema/** | ||
| - arrow-select/** | ||
| - arrow-string/** |
Contributor
Author
There was a problem hiding this comment.
arrow-flight doesn't depend on this crate and so this can be removed
tustvold
commented
Dec 8, 2022
| gt_eq_utf8_scalar, | ||
| vec![false, false, true, true] | ||
| ); | ||
| test_flag_utf8!( |
Contributor
Author
There was a problem hiding this comment.
These tests are moved to arrow-string
tustvold
commented
Dec 8, 2022
|
|
||
| let array: ArrayRef = Arc::new(array); | ||
| let array = crate::compute::cast(&array, &DataType::Float64).unwrap(); | ||
| let array = array.unary::<_, Float64Type>(|x| x as f64); |
Contributor
Author
There was a problem hiding this comment.
It makes me happy that it is now really easy to define your own kernels. This avoids needing a dev dependency on arrow-cast
tustvold
commented
Dec 8, 2022
| run: cargo clippy -p arrow-schema --all-targets --all-features -- -D warnings | ||
| - name: Clippy arrow-array with all features | ||
| run: cargo clippy -p arrow-array --all-targets --all-features -- -D warnings | ||
| - name: Clippy arrow-array with all features except SIMD |
Contributor
Author
There was a problem hiding this comment.
I created rust-lang/cargo#11467 to track making this less error prone
alamb
approved these changes
Dec 8, 2022
alamb
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me -- again I think it is worth being overly conservative and running benchmarks again to ensure we didn't cause any performance regressions accidentally
| [package] | ||
| name = "arrow-ord" | ||
| version = "28.0.0" | ||
| description = "Ordering kernels for arrow arrays" |
Contributor
There was a problem hiding this comment.
Would "comparison kernels" be a more accurate description?
Contributor
Author
There was a problem hiding this comment.
There are sort kernels in there, so it is kind of kernels that relate to the ordering of elements? Maybe? I don't really feel strongly, was just trying to justify why it is arrow-ord and not arrow-cmp or something 😅
Contributor
Author
|
Benchmarks just show noise |
Contributor
Author
|
Sort kernels also show just noise |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #2594
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?