Skip to content

Tweak row format docs#3191

Merged
tustvold merged 1 commit into
apache:masterfrom
tustvold:tweak-row-format-docs
Nov 25, 2022
Merged

Tweak row format docs#3191
tustvold merged 1 commit into
apache:masterfrom
tustvold:tweak-row-format-docs

Conversation

@tustvold

Copy link
Copy Markdown
Contributor

I found the new docs added in #3094 quite hard to read, largely due to the way rustdoc formatted the output. This tweaks the output to be a little easier on the eyes.

Before

image

After

image

@tustvold tustvold added the development-process Related to development process of arrow-rs label Nov 25, 2022
@github-actions github-actions Bot added the arrow Changes to the arrow crate label Nov 25, 2022

@xudong963 xudong963 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@tustvold tustvold merged commit cbe5af0 into apache:master Nov 25, 2022
@ursabot

ursabot commented Nov 25, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 3998bed and contender = cbe5af0. cbe5af0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate development-process Related to development process of arrow-rs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants