Skip to content

Derive clone for arrays#3184

Merged
viirya merged 4 commits into
apache:masterfrom
tustvold:derive-clone-array
Nov 25, 2022
Merged

Derive clone for arrays#3184
viirya merged 4 commits into
apache:masterfrom
tustvold:derive-clone-array

Conversation

@tustvold

@tustvold tustvold commented Nov 24, 2022

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

Being able to go from a reference to an owned value is often useful

What changes are included in this PR?

Are there any user-facing changes?

@tustvold tustvold requested a review from viirya November 24, 2022 17:58
@github-actions github-actions Bot added the arrow Changes to the arrow crate label Nov 24, 2022
tustvold
tustvold commented Nov 24, 2022
View reviewed changes
Comment thread arrow-array/src/raw_pointer.rs Outdated
/// self-reference a [arrow_buffer::Buffer] from
/// [arrow_data::ArrayData], as a pointer to the beginning of its
/// contents.
#[derive(Copy, Clone)]

@tustvold tustvold Nov 24, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't make RawPtrBox any more unsafe than it already is, it is effectively just a pointer

viirya
viirya approved these changes Nov 25, 2022
View reviewed changes

@viirya viirya left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be useful.

@viirya viirya merged commit 2c86895 into apache:master Nov 25, 2022
@ursabot

ursabot commented Nov 25, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 2460c7b and contender = 2c86895. 2c86895 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viirya viirya viirya approved these changes

@xudong963 xudong963 xudong963 approved these changes

Assignees

No one assigned

Labels

arrow Changes to the arrow crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tustvold @ursabot @viirya @xudong963