Skip to content

Remove unused range module#3085

Merged
tustvold merged 1 commit into
apache:masterfrom
tustvold:remove-unused-ranges-module
Nov 11, 2022
Merged

Remove unused range module#3085
tustvold merged 1 commit into
apache:masterfrom
tustvold:remove-unused-ranges-module

Conversation

@tustvold

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

This was added by @Ted-Jiang in #1791 but hasn't ever been hooked up. It overlaps sufficiently with the RowSelector logic, that I think it can be removed.

What changes are included in this PR?

Are there any user-facing changes?

@tustvold tustvold requested a review from Ted-Jiang November 10, 2022 21:42
@github-actions github-actions Bot added the parquet Changes to the parquet crate label Nov 10, 2022
pub mod index_reader;

#[cfg(test)]
pub(crate) mod range;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems it is only for test?

@tustvold tustvold merged commit 0139682 into apache:master Nov 11, 2022
@ursabot

ursabot commented Nov 11, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 5226258 and contender = 0139682. 0139682 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@Ted-Jiang

Copy link
Copy Markdown
Member

@tustvold Thanks, It can be removed, I have intended to use bytes offset as input, now use the selection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parquet Changes to the parquet crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants