Fix take string on sliced indices#2960
Conversation
|
|
||
| nulls = match indices.data_ref().null_buffer() { | ||
| Some(buffer) => { | ||
| Some(buffer_bin_and(buffer, 0, &null_buf.into(), 0, data_len)) |
There was a problem hiding this comment.
The bug is that this doesn't take into account any offset that indices may have, it should be
buffer_bin_and(buffer, indices.offset(), &null_buf.into(), 0, data_len)
However, this code is completely redundant as we already check the validity of indices in the loop above when constructing this mask, and so we can just remove this
|
Benchmark runs are scheduled for baseline = 0a115d6 and contender = 87ac05b. 87ac05b is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #1049
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?