ipc: clear variadicCounts in recordEncoder.reset()#631
Merged
zeroshade merged 1 commit intoapache:mainfrom Jan 14, 2026
Merged
Conversation
The reset() function did not clear variadicCounts, causing it to accumulate across batch encodings. This produces malformed IPC where each DictionaryBatch contains variadic counts from all previous batches, which other IPC reader implementations do not expect (e.g. arrow-rs) Signed-off-by: Alfonso Subiotto Marques <alfonso.subiotto@polarsignals.com>
Contributor
Author
|
cc @zeroshade, would it be possible to backport and release 18.5.1? |
zeroshade
approved these changes
Jan 14, 2026
Member
zeroshade
left a comment
There was a problem hiding this comment.
I can start working on backporting this and releasing an 18.5.1 this week.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reset() function did not clear variadicCounts, causing it to accumulate across batch encodings. This produces malformed IPC where each DictionaryBatch contains variadic counts from all previous batches, which other IPC reader implementations do not expect (e.g. arrow-rs)
Rationale for this change
arrow-rs was returning errors when reading IPC files written by arrow-go
What changes are included in this PR?
Clearing state on reset
Are these changes tested?
Yes
Are there any user-facing changes?
No