Merged
Conversation
Adds grpc.Trailer parameters to TestGetSetGetSessionOptions and TestSetRemoveSessionOptions to ensure session cookies are fully processed before subsequent operations. This fixes race conditions where GetSessionOptions would execute before SetSessionOptions trailers were processed, causing the test to read stale session state. Fixes macOS CI failures in PR apache#626.
Adds a 50ms delay after sending cookie deletion to allow client middleware time to process the MaxAge=-1 cookie before the next request validates that cookies are empty. This fixes a race condition where the validation request would start before cookie deletion completed, causing test to fail with 'expected map[], got map[foo:baz]' on Windows CI. Fixes Windows CI failure in PR apache#626.
…estStatelessServerSessionCookies - TestCookiesClone: Add 50ms delay after setting cookies before validation to allow client middleware time to process Set-Cookie headers - TestStatelessServerSessionCookies: Reinitialize trailer metadata before each RPC call to avoid stale metadata issues These fixes address race conditions where: 1. Cookie middleware's HeadersReceived processes headers asynchronously 2. gRPC trailer metadata can contain stale values if reused across calls Fixes ARM64 and macOS CI failures in PR apache#629.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes for flaky FlightSQL tests that should hopefully reduce the CI failures
What changes are included in this PR?
Using grpc.Trailer for all the RPC calls in some of the test cases where we missed them should hopefully fix the race conditions that were being seen.
Are these changes tested?
Yes, they are part of tests in CI
Are there any user-facing changes?
No