Skip to content

chore: fix macOS Go 1.24 CI#334

Merged
zeroshade merged 2 commits intoapache:mainfrom
lidavidm:minor-macos-ci
Mar 25, 2025
Merged

chore: fix macOS Go 1.24 CI#334
zeroshade merged 2 commits intoapache:mainfrom
lidavidm:minor-macos-ci

Conversation

@lidavidm
Copy link
Copy Markdown
Member

Rationale for this change

CI was failing.

What changes are included in this PR?

Explicitly include Arrow in PKG_CONFIG_PATH.

Are these changes tested?

Yes

Are there any user-facing changes?

No

@lidavidm lidavidm marked this pull request as draft March 25, 2025 06:26
@lidavidm lidavidm marked this pull request as ready for review March 25, 2025 06:38
Copy link
Copy Markdown
Contributor

@singh1203 singh1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Copy Markdown
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Copy link
Copy Markdown
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this only failing for go 1.24 though?

@zeroshade zeroshade merged commit 276892c into apache:main Mar 25, 2025
23 checks passed
@lidavidm
Copy link
Copy Markdown
Member Author

That I couldn't figure out. The Homebrew installation was the same, so I don't see how Go 1.23 actually worked before (they should always have failed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants