Fix: Handle null values in PlainFixedLenByteArrayEncoder gracefully#320
Merged
zeroshade merged 3 commits intoapache:mainfrom Mar 24, 2025
Merged
Fix: Handle null values in PlainFixedLenByteArrayEncoder gracefully#320zeroshade merged 3 commits intoapache:mainfrom
zeroshade merged 3 commits intoapache:mainfrom
Conversation
Signed-off-by: Saurabh Kumar Singh <singh1203.ss@gmail.com>
zeroshade
requested changes
Mar 20, 2025
Member
zeroshade
left a comment
There was a problem hiding this comment.
Can we add a new test that would fail without this change?
Contributor
Author
Sure @zeroshade I'm on it. |
Signed-off-by: Saurabh Kumar Singh <singh1203.ss@gmail.com>
zeroshade
approved these changes
Mar 24, 2025
Contributor
Author
|
Thank you. @zeroshade |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #71
Rationale for this change
Ensures
PlainFixedLenByteArrayEncoderhandles null values gracefully in non-nullable fields by writing zero-filled bytes instead of panicking, maintaining consistency withDictFixedLenByteArrayEncoder.What changes are included in this PR?
Are these changes tested?
Yes:
Are there any user-facing changes?
Not Sure (Need possible guidance if required)