refactor(arrow/array): replace some codegen with generics#315
Merged
zeroshade merged 1 commit intoapache:mainfrom Mar 17, 2025
Merged
refactor(arrow/array): replace some codegen with generics#315zeroshade merged 1 commit intoapache:mainfrom
zeroshade merged 1 commit intoapache:mainfrom
Conversation
lidavidm
approved these changes
Mar 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Simplifying code and removing old code-gen
What changes are included in this PR?
Replacing the old
numeric.gen.goandnumeric.gen.go.tmplwith a new version built using go generics.Are these changes tested?
All the same unit tests will test the new versions of the objects
Are there any user-facing changes?
There shouldn't be any user-facing changes. Everything was designed to avoid any public breaking changes.