feat(arrow/array): convert RecordReader and iterators#314
Merged
zeroshade merged 2 commits intoapache:mainfrom Mar 17, 2025
Merged
feat(arrow/array): convert RecordReader and iterators#314zeroshade merged 2 commits intoapache:mainfrom
zeroshade merged 2 commits intoapache:mainfrom
Conversation
lidavidm
approved these changes
Mar 16, 2025
|
|
||
| func (ir *iterReader) Retain() { ir.refCount.Add(1) } | ||
| func (ir *iterReader) Release() { | ||
| debug.Assert(ir.refCount.Load() > 0, "too many releases") |
Member
There was a problem hiding this comment.
Technically this is a TOC/TOU error but it's a debug assertion so probably not a big deal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
With the advent of Go iterators via the iter module, we should provide some easy compatibility and canonicity for handling streams of record batches.
What changes are included in this PR?
Two new functions:
ReaderFromIterandIterFromReaderfor converting between theRecordReaderinterface and an iterator of Records and errors. This should make it easy to integrate in various packages without forcing refactors or boilerplate code.Are these changes tested?
Yes, unit tests are added for them.
Are there any user-facing changes?
No.