docs(license): update LICENSE.txt#290
Conversation
|
Thank you! Looks good to me, even though it does not add any copyright notices for ASF. I was expecting something like: Is there any reason you do not want this to be in the git repo? I don't care strongly about legal reasons here, but there is a lot of license scanners that search for 'Copyright' as a string to find licenses and authors. It would have saved me some uncertainty when trying to figure out Debian's debian/copyright file for this package if there were more clear copyright notices pointing at the ASF. Sometimes the exact legal name is significant too. |
|
The In addition every source file heading starts with Is that sufficient? |
kou
left a comment
There was a problem hiding this comment.
+1
In general, ASF projects write "Copyright YYYY The Apache Software Foundation" in NOTICE not LICENSE.
See also: https://infra.apache.org/licensing-howto.html#step-by-step
|
Thanks ! As you removed safe-math, the About the code copied from LLVM, it's OK in the The dependency copyright doesn't have to be in On the other hand, the project copyright should be in the So, @zeroshade you are good here ! Thanks ! |
Rationale for this change
Fixes #275
What changes are included in this PR?
Removing "safe-math" from being vendored as it's no longer being used. Updating the LICENSE.txt with all appropriate information including files which contain code that has been copied from other projects.