feat(internal/encoding): add Discard method to decoders#280
Merged
zeroshade merged 2 commits intoapache:mainfrom Feb 17, 2025
Merged
feat(internal/encoding): add Discard method to decoders#280zeroshade merged 2 commits intoapache:mainfrom
zeroshade merged 2 commits intoapache:mainfrom
Conversation
lidavidm
approved these changes
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Building towards proper support for Skipping rows to address #278 we need to be able to efficiently discard values from decoders rather than actively having to allocate a buffer and read into it. This makes the skipping/seeking within a page more efficient.
What changes are included in this PR?
Adding a new
Discardmethod to theDecoderinterface along with implementations for all the various decodersAre these changes tested?
Yes, tests are added for the various decoders.
Are there any user-facing changes?
No, this is in an internal package.