fix(arrow/bitutil): fix bitmap ops on 32-bit platforms#277
Merged
zeroshade merged 1 commit intoapache:mainfrom Feb 12, 2025
Merged
fix(arrow/bitutil): fix bitmap ops on 32-bit platforms#277zeroshade merged 1 commit intoapache:mainfrom
zeroshade merged 1 commit intoapache:mainfrom
Conversation
Member
Author
lidavidm
approved these changes
Feb 11, 2025
Member
lidavidm
left a comment
There was a problem hiding this comment.
We could maybe test with qemu?
Member
Member
|
I think that we can use x86_64 ubuntu-latest runner for it. In general, x86_64 Linux kernel can execute i386 binary. Go can build i386 binary on x86_64 by |
Member
Author
|
True, I could create a docker config that just runs the scripts with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes the broken 32-bit arch tests identified by #32
What changes are included in this PR?
Defining the
opAlignedpure go fallback methods for bitmap operations.Are these changes tested?
Yes, it makes the tests succeed properly on
GOARCH=386Are there any user-facing changes?
No.