GH-39041:[R] Improve update-checksum.R output
#39042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paleolimbot
approved these changes
Dec 5, 2023
Member
paleolimbot
left a comment
There was a problem hiding this comment.
You're the only person who is likely to see this output so I trust that the output is useful to you! I do think you want cat() instead of print() though (which will get rid of the extraneous [1] prefixes in your output).
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 7346bdf. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
raulcd
pushed a commit
that referenced
this pull request
Dec 6, 2023
### Rationale for this change The script was to quiet. ### What changes are included in this PR? Fix regex and add some output: ``` Rscript tools/update-checksums.R 14.0.0 1 ✘ [1] "Extracting libarrow binary paths from tasks.yml" [1] "Downloading windows/arrow-14.0.0.zip.sha512" [1] "Converting windows/arrow-14.0.0.zip to windows style line endings" [1] "Downloading linux-openssl-1.0/arrow-14.0.0.zip.sha512" [1] "Downloading linux-openssl-1.1/arrow-14.0.0.zip.sha512" [1] "Downloading linux-openssl-3.0/arrow-14.0.0.zip.sha512" [1] "Downloading darwin-arm64-openssl-1.1/arrow-14.0.0.zip.sha512" [1] "Downloading darwin-arm64-openssl-3.0/arrow-14.0.0.zip.sha512" [1] "Downloading darwin-x86_64-openssl-1.1/arrow-14.0.0.zip.sha512" [1] "Downloading darwin-x86_64-openssl-3.0/arrow-14.0.0.zip.sha512" [1] "Checksums updated successfully!" ``` ### Are these changes tested? locally ### Are there any user-facing changes? no * Closes: #39041 Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### Rationale for this change The script was to quiet. ### What changes are included in this PR? Fix regex and add some output: ``` Rscript tools/update-checksums.R 14.0.0 1 ✘ [1] "Extracting libarrow binary paths from tasks.yml" [1] "Downloading windows/arrow-14.0.0.zip.sha512" [1] "Converting windows/arrow-14.0.0.zip to windows style line endings" [1] "Downloading linux-openssl-1.0/arrow-14.0.0.zip.sha512" [1] "Downloading linux-openssl-1.1/arrow-14.0.0.zip.sha512" [1] "Downloading linux-openssl-3.0/arrow-14.0.0.zip.sha512" [1] "Downloading darwin-arm64-openssl-1.1/arrow-14.0.0.zip.sha512" [1] "Downloading darwin-arm64-openssl-3.0/arrow-14.0.0.zip.sha512" [1] "Downloading darwin-x86_64-openssl-1.1/arrow-14.0.0.zip.sha512" [1] "Downloading darwin-x86_64-openssl-3.0/arrow-14.0.0.zip.sha512" [1] "Checksums updated successfully!" ``` ### Are these changes tested? locally ### Are there any user-facing changes? no * Closes: apache#39041 Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de> Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The script was to quiet.
What changes are included in this PR?
Fix regex and add some output:
Are these changes tested?
locally
Are there any user-facing changes?
no
update-checksums.R#39041