AMQ-9475 - ConsumerControl commands should not auto create wildcard dests#1200
Merged
Conversation
dests This fixes an issue where wildcard destinations could be inadvertently created by ConsumerControl commands which could lead to problems. The processing logic for this command now will only look up existing destinations if they exist.
mattrpav
approved these changes
Apr 10, 2024
Contributor
Author
|
I'll let the tests finish and then I'll merge and backport. |
Contributor
Contributor
Author
Thanks for the quick test, glad that worked for you. This will be included in the next bug fix releases for 6.1.x and 5.18.x. 5.18.4 is already under vote so this will be in 5.18.5 but obviously you can just build your own version as you did. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where wildcard destinations could be inadvertently created by ConsumerControl commands which could lead to problems. The processing logic for this command now will only look up existing destinations if they exist.